Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo updated #2568

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Logo updated #2568

merged 3 commits into from
Jan 8, 2025

Conversation

KMajkrzakOctopus
Copy link
Contributor

After:
Screenshot 2024-11-20 at 18 45 29
Screenshot 2024-11-20 at 18 45 34

@KMajkrzakOctopus
Copy link
Contributor Author

@steve-fenton-octopus could you take a look what is wrong in the deploy to channel pipeline? I don't want to mess up anything but seems like something is wrong in here:
tests/bookmark.spec.ts

@KMajkrzakOctopus
Copy link
Contributor Author

@steve-fenton-octopus could you take a look what is wrong in the deploy to channel pipeline? I don't want to mess up anything but seems like something is wrong in here: tests/bookmark.spec.ts

Nevermind turns out someone fixed that with a latest pr

@steve-fenton-octopus
Copy link
Contributor

@KMajkrzakOctopus as the SVG is growing, I wonder if it might be an idea to move it into an .svg file so browsers can cache it, rather than inlining it? What are your thoughts?

@steve-fenton-octopus steve-fenton-octopus merged commit 39ce564 into main Jan 8, 2025
4 checks passed
@steve-fenton-octopus steve-fenton-octopus deleted the km/logo-update branch January 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants