Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include dot-files support in glob selection #9

Merged
merged 8 commits into from
Feb 17, 2023

Conversation

benPearce1
Copy link
Contributor

@benPearce1 benPearce1 commented Feb 16, 2023

[sc-40495]

Using the following action yaml

      - name: Run build script
        run: | 
          mkdir work
          cd work
          echo "test output" > .dotfile
          cat .dotfile
          touch test.txt
          touch no-extension
        shell: bash
      - name: Create Zip Package for Octopus Deploy
      # You may pin to the exact commit or the version.
        uses: OctopusDeploy/create-zip-package-action@06107900912e6dc6be9a56f4340cd54a8024c61a
        with:
          package_id: output
          version: 1.0.0
          output_folder: ./pack
          base_path: .
          files: |
            work/**/*

produces a zip file with the following contents:
image

Also, added a developers guide

@benPearce1 benPearce1 changed the title updated api-client reference for glob dot-file support fix: include dot-files support in glob selection Feb 16, 2023
@benPearce1 benPearce1 marked this pull request as ready for review February 17, 2023 00:45
@benPearce1 benPearce1 requested a review from a team February 17, 2023 00:45
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #40495: Dot-files are not included by default in pack commands.

Copy link
Contributor

@slewis74 slewis74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of suggestions for the dev guide

DEVELOPERS_GUIDE.md Outdated Show resolved Hide resolved
DEVELOPERS_GUIDE.md Outdated Show resolved Hide resolved
DEVELOPERS_GUIDE.md Outdated Show resolved Hide resolved
benPearce1 and others added 3 commits February 17, 2023 11:02
Co-authored-by: Shannon Lewis <[email protected]>
Co-authored-by: Shannon Lewis <[email protected]>
Co-authored-by: Shannon Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants