Fixes format for project-group view #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nate-christensen
force-pushed
the
main
branch
from
154e971 to
bae9fb1
Compare
tleed5
requested changes
Feb 29, 2024
go.mod
Outdated
| @@ -24,6 +24,7 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/OctopusDeploy/go-octopusdeploy v1.8.6 // indirect | |||
There was a problem hiding this comment.
This isn't been used by the looks of it, running go mod tidy should remove this and also fix the merge conflict
pkg/cmd/projectgroup/view/view.go
Outdated
| } | ||
|
|
||
| return nil | ||
| return output.PrintArray(allProjects, cmd, output.Mappers[*projects.Project]{ |
There was a problem hiding this comment.
For the basic output format, it should return what it did previously, otherwise we are losing some functionality.
Example of the previous basic output.
Default Project Group (ProjectGroups-1)
No description provided
Projects:
NonVcs (nonvcs)
VCS (vcs)
View this project group in Octopus Deploy: http://localhost:8066/app#/Spaces-1/projects?projectGroupId=ProjectGroups-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running octopus project-group view "group" -f json, it wouldn't print in json or anything else for that matter.
This fixes an issue I ran into as well as half of issue #312. I can try to fix the project view one as well if this is merged.