Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker manifest step to deployment process #84

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Add docker manifest step to deployment process #84

merged 1 commit into from
Jan 10, 2024

Conversation

veochen-octopus
Copy link
Contributor

@veochen-octopus veochen-octopus commented Jan 9, 2024 •
edited
Loading

This allows us to combine windows and linux into a single docker manifest.

Changes include:

  • adding a new step to both ubuntu and windows to create a combined manifest
  • update some of the variable usage in the existing docker push step to make the ☝️ step easier

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@veochen-octopus veochen-octopus force-pushed the veo/update-deployment-process branch from 7bd1a70 to 8c1d677 Compare January 9, 2024 23:00
@veochen-octopus veochen-octopus marked this pull request as ready for review January 10, 2024 02:06
IsaacCalligeros95
IsaacCalligeros95 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veochen-octopus veochen-octopus merged commit 4b7d008 into master Jan 10, 2024
5 of 6 checks passed
@veochen-octopus veochen-octopus deleted the veo/update-deployment-process branch January 10, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacCalligeros95 IsaacCalligeros95 IsaacCalligeros95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veochen-octopus @CLAassistant @IsaacCalligeros95