Bump step template #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This paves the way for adding the "combined manifest" step to both ubuntu and windows projects on
deploy. The changes are on the project variables. I've added 3 new variables to each project (ubuntu and windows)WorkerTools.Tags.MajorWorkerTools.Tags.MinorWorkerTools.Tags.Oswhere the
MajorandMinorare just the semver part without the os suffix. The concat then happens in the step template source. These values are required for the combined manifest.Adding them as new variables instead of modifying the existing variable just so we have some backward compatibility until the PR is merged. The old variables can be cleaned up once this is merged and the changes have taken effect.