Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning windows base image for layer sharing #74

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

IsaacCalligeros95
Copy link
Contributor

@IsaacCalligeros95 IsaacCalligeros95 commented Aug 16, 2023

Since moving to Windows 4.8 base image, we ran into caching issues due to the base layer not being shared. Previous images had a shared base layer and patches applied on top. This is no longer happening. This change pins to a specific version of the base image. This still applies patches and updates after the base layer.

Internal thread

Worker Tools 5.1.0 image layers
Worker Tools 5.1.0

Image layers at the time of making this change, note the Install Updates patch version.
This change

@IsaacCalligeros95 IsaacCalligeros95 requested a review from a team August 16, 2023 01:04
Copy link
Contributor

@veochen-octopus veochen-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We'll also need to find a long-term solution but this will get us around the oversize issue for now.

@veochen-octopus veochen-octopus merged commit 5592ecf into master Aug 17, 2023
@veochen-octopus veochen-octopus deleted the isaac/pin-windows-base branch August 17, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants