issue #126 - don't crash on uninitialized properties #655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the liberty of creating a duplicate of #370 that fixes #126.
I have copy/pasted code from the former, but changed the way the guard is implemented by simply writing the extract this way:
Hiding engine errors is probably a terrible thing to do, although it works.
There is a question remaining open, should we instead write this ?
I guess simply not setting the value in the array is more representative of what is happening: the value don't get set in the array since it wasn't set at all in the object. I don't care which is the best, both will work for most my use cases, or can be worked around easily.