#126: Refactor extract method generation to private method

Ocramius · May 25, 2023 · c202991 · c202991
1 parent e38b93c
commit c202991
Showing 1 changed file with 23 additions and 13 deletions.
diff --git a/src/GeneratedHydrator/CodeGenerator/Visitor/HydratorMethodsVisitor.php b/src/GeneratedHydrator/CodeGenerator/Visitor/HydratorMethodsVisitor.php
@@ -124,6 +124,28 @@ private function generatePropertyHydrateCall(ObjectProperty $property, string $i
         ];
     }
 
+    /**
+     * @return string[]
+     *
+     * @psalm-return list<string>
+     */
+    private function generatePropertyExtractCall(ObjectProperty $property): array
+    {
+        $propertyName        = $property->name;
+        $assignmentStatement = "\$values['" . $propertyName . "'] = \$object->" . $propertyName . ';';
+        $requiresGuard       = $property->hasType && !($property->hasDefault || $property->allowsNull);
+
+        if (!$requiresGuard) {
+            return ['    ' . $assignmentStatement];
+        }
+
+        return [
+            '    if (isset($object->' . $propertyName . ')) {',
+            '        ' . $assignmentStatement,
+            '    }'
+        ];
+    }
+
     private function replaceConstructor(ClassMethod $method): void
     {
         $method->params = [];
@@ -145,19 +167,7 @@ private function replaceConstructor(ClassMethod $method): void
             // Extract closures
             $bodyParts[] = '$this->extractCallbacks[] = \\Closure::bind(static function ($object, &$values) {';
             foreach ($properties as $property) {
-                $propertyName  = $property->name;
-                $requiresGuard = $property->hasType && ! ($property->hasDefault || $property->allowsNull);
-                $indent        = $requiresGuard ? '        ' : '    ';
-
-                if ($requiresGuard) {
-                    $bodyParts[] = '    if (isset($object->' . $propertyName . ')) {';
-                }
-
-                $bodyParts[]  = $indent . "\$values['" . $propertyName . "'] = \$object->" . $propertyName . ';';
-
-                if ($requiresGuard) {
-                    $bodyParts[] = '    }';
-                }
+                $bodyParts = array_merge($bodyParts, $this->generatePropertyExtractCall($property));
             }
 
             $bodyParts[] = '}, null, ' . var_export($className, true) . ');' . "\n";