Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): spanish translation #157

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Conversation

DanielGallo84
Copy link
Contributor

🍰 Pullrequest

Issues

  • None

Todo

  • None

@DanielGallo84 DanielGallo84 self-assigned this Jun 28, 2024
mahula
mahula previously requested changes Jul 2, 2024
Copy link
Contributor

@mahula mahula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution.
Please change the two things mentioned.

What about /en/imprint/ and /en/privacy-policy/?
Were they left out because of their legal context?

docs/es/README.md Outdated Show resolved Hide resolved
docs/es/contact/README.md Outdated Show resolved Hide resolved
Tirokk
Tirokk previously approved these changes Jul 3, 2024
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DanielGallo84

Really cool that you cared for the Spanish version of our ocelot.social project website.
😍💫

I approve even @mahula requested changes I agree with.
And I take this as notes in the follow up issue #158 .

docs/es/contact/README.md Outdated Show resolved Hide resolved
docs/es/contact/README.md Outdated Show resolved Hide resolved
docs/es/README.md Outdated Show resolved Hide resolved
@Tirokk Tirokk dismissed mahula’s stale review July 3, 2024 11:29

I take your requests as notes in the follow up issue #158 🙏🏼

Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you cared already for @mahula suggestions. 🙏🏼

I approve your work. 🚀🚀💫

@DanielGallo84 DanielGallo84 merged commit c2ea1f3 into master Jul 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants