Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(webapp): fix coverage #6361

Merged
merged 10 commits into from
Jun 7, 2023
Merged

refactor(webapp): fix coverage #6361

merged 10 commits into from
Jun 7, 2023

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented Jun 1, 2023

🍰 Pullrequest

Fixed coverage reporting. The coverage report is now properly generated using @vue/vue2-jest instead of vue-jest.

Additionally this defines coverageProvider: "v8" to get proper highlighting in the coverage html files.
See: https://jestjs.io/docs/configuration#coverageprovider-string

Apparently template and script elements are included in the coverage threshold and this leads to a high coverage value. Still this is an improvement since coverage now is correct(apparently was before as well) and is debugable via the html.

image

Issues

Todo

  • Investigate if we can use babel as coverage provider to get more meaningful coverage values. -> not working at the moment

@ulfgebhardt ulfgebhardt requested a review from Mogge June 1, 2023 10:01
@ulfgebhardt ulfgebhardt marked this pull request as ready for review June 1, 2023 10:45
@ulfgebhardt ulfgebhardt self-assigned this Jun 1, 2023
@ulfgebhardt ulfgebhardt added bug Something isn't working service: webapp labels Jun 1, 2023
Mogge
Mogge previously requested changes Jun 5, 2023
Copy link
Contributor

@Mogge Mogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn test pages/search/search-results.spec.js

yarn test pages/post/edit/_id.spec.js

Throw warnings. Please fix this

@ulfgebhardt ulfgebhardt requested a review from Mogge June 5, 2023 18:53
@ulfgebhardt ulfgebhardt merged commit 9ab1ada into master Jun 7, 2023
@ulfgebhardt ulfgebhardt deleted the fix-coverage branch June 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working service: webapp
Projects
Development

Successfully merging this pull request may close these issues.

3 participants