Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add biofouling examples to RT and recovery #139

Merged
merged 8 commits into from
Oct 18, 2021

Conversation

soerenthomsen
Copy link
Member

@soerenthomsen soerenthomsen commented Oct 18, 2021

I added the 4 images provided by Gerd Krahmann and Mario Mueller.

@gkrahmann I now splitted these parts on the RTQC and the recovery section but made links to the the images.

This closes #24 and relates to #113

@github-actions
Copy link

github-actions bot commented Oct 18, 2021

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: 059e7ad
✅ Deployment Preview URL: https://616d348dca5b34c3410e0e5c--oxygensop.netlify.app

Copy link
Contributor

@gkrahmann gkrahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads fine. As md in the browser the figure captions look not so great. Is that different in the pdfs?

@soerenthomsen
Copy link
Member Author

Thanks for checking so quickly. At the moment we are not building a pdf but the final online document is here: https://oceangliderscommunity.github.io/Oxygen_SOP/sections/oxygen_rtqc.html

To assess how the changes look like before merging you can have a look here: https://616d32c5117afe921c0a4059--oxygensop.netlify.app/readme, which is provided by the GitHub action each time we make a pull request.

Please also officially approve when you are done with your review.

@gkrahmann
Copy link
Contributor

That link looks much better. I look at it in the review part 'view file' under the three dots.

Copy link
Contributor

@gkrahmann gkrahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@soerenthomsen
Copy link
Member Author

Yes in the md file it is not so beautiful but thats ok. We only direct the readers to the jupyter book which is build. Julius added this action which you can see at the top of this conversion so that you can see how these changes will look like in the real deployment / book before merging. This helps to identify errors before merging and the main document stays clean.

@soerenthomsen soerenthomsen merged commit 6ed5950 into OceanGlidersCommunity:main Oct 18, 2021
@gkrahmann
Copy link
Contributor

one comment.
I uploaded full size images (several MB). They load very slowly. Maybe we reduce the resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observe data for evidence of biofouling
2 participants