-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add biofouling examples to RT and recovery #139
Conversation
The image, text and figure caption has been provided by Gerd Krahmann.
This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below. 🔍 Git commit SHA: 059e7ad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads fine. As md in the browser the figure captions look not so great. Is that different in the pdfs?
Thanks for checking so quickly. At the moment we are not building a pdf but the final online document is here: https://oceangliderscommunity.github.io/Oxygen_SOP/sections/oxygen_rtqc.html To assess how the changes look like before merging you can have a look here: https://616d32c5117afe921c0a4059--oxygensop.netlify.app/readme, which is provided by the GitHub action each time we make a pull request. Please also officially approve when you are done with your review. |
That link looks much better. I look at it in the review part 'view file' under the three dots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Yes in the md file it is not so beautiful but thats ok. We only direct the readers to the jupyter book which is build. Julius added this action which you can see at the top of this conversion so that you can see how these changes will look like in the real deployment / book before merging. This helps to identify errors before merging and the main document stays clean. |
one comment. |
I added the 4 images provided by Gerd Krahmann and Mario Mueller.
@gkrahmann I now splitted these parts on the RTQC and the recovery section but made links to the the images.
This closes #24 and relates to #113