Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make particles easier to use #220

Merged
merged 34 commits into from
Oct 14, 2024
Merged

Make particles easier to use #220

merged 34 commits into from
Oct 14, 2024

Conversation

jagoosw
Copy link
Collaborator

@jagoosw jagoosw commented Oct 3, 2024

I started this intending to work on the giant kelp growth model, but realised it would be much easier if I finally cleaned up how we do particle models. This PR turns BiogeochemicalParticles into a type which stores biogeochemistry which specifies the evolution of fields in the same way as continuous biogeochemical models, e.g.:

(kelp::SugarKelp)(::Val{:A}, t, A, N, C, ...)

This separates out the numerics from the model so should make it a lot easier to implement other models.

I suppose I need to do this to sediments next...

@jagoosw jagoosw marked this pull request as ready for review October 4, 2024 14:03
@jagoosw jagoosw merged commit ba6b4ad into main Oct 14, 2024
5 checks passed
@jagoosw jagoosw deleted the jsw/giant-kelp-growth branch October 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant