Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/validatorapi: omit if empty on the proposer config #975

Conversation

ciaranmcveigh5
Copy link
Contributor

  • omit if empty on propser config overrides currently getting -,"builder":{"enabled":false,"registration_overrides":null}

category: feature
ticket: #849

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #975 (60fc856) into main (b42075f) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #975      +/-   ##
==========================================
+ Coverage   54.14%   54.19%   +0.04%     
==========================================
  Files         116      116              
  Lines       12750    12750              
==========================================
+ Hits         6904     6910       +6     
+ Misses       4830     4826       -4     
+ Partials     1016     1014       -2     
Impacted Files Coverage Δ
core/validatorapi/teku.go 0.00% <ø> (ø)
core/dutydb/memory.go 70.63% <0.00%> (-1.28%) ⬇️
app/app.go 58.80% <0.00%> (+1.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ciaranmcveigh5 ciaranmcveigh5 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 15, 2022
@obol-bulldozer obol-bulldozer bot merged commit 57aae96 into ObolNetwork:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants