core/tracker: validate events from peers #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 54.18% 53.84% -0.34%
==========================================
Files 116 116
Lines 12750 12811 +61
==========================================
- Hits 6908 6898 -10
- Misses 4831 4893 +62
- Partials 1011 1020 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
corverroos
approved these changes
Aug 15, 2022
core/tracker/tracker.go
Outdated
| if e.component == parSigEx || e.component == parSigDBInternal { | ||
| if e.component == parSigEx { | ||
| if err := validateParticipation(duty, e.pubkey, allEvents); err != nil { | ||
| log.Warn(ctx, "Unexpected event found", err, z.Int("ShareIdx", e.shareIdx)) |
There was a problem hiding this comment.
moving logging to reporter
core/tracker/tracker.go
Outdated
| @@ -113,11 +113,11 @@ func (t *Tracker) Run(ctx context.Context) error { | |||
| t.failedDutyReporter(ctx, duty, failed, failedComponent, failedMsg) | |||
|
|
|||
| // Analyse peer participation | |||
| participatedShares, err := analyseParticipation(t.events[duty]) | |||
| participatedShares, unexpectedPeers, err := analyseParticipation(ctx, duty, t.events) | |||
core/tracker/tracker.go
Outdated
| continue | ||
| } | ||
|
|
||
| if e.shareIdx == 0 { |
There was a problem hiding this comment.
you can assume shareIdx is valid since we verify partial signatures when received in parsigex
core/tracker/tracker.go
Outdated
| } | ||
|
|
||
| // validateParticipation validates events from peers for a given duty. | ||
| func validateParticipation(duty core.Duty, pubkey core.PubKey, allEvents map[core.Duty][]event) error { |
There was a problem hiding this comment.
nit: isParSigEventExpected return true if partially signed data events is expected for the given duty and pubkey. Partially signed data events are generated by parsigex and parsigdb.
| return nil, nil, errors.New("shareIdx empty", z.Any("component", e.component)) | ||
| } | ||
| resp[e.shareIdx] = true | ||
| } else if e.component == parSigDBInternal { |
There was a problem hiding this comment.
you also need to check if parSigDBInternal is expected.
core/tracker/tracker.go
Outdated
|
|
||
| // validateParticipation validates events from peers for a given duty. | ||
| func validateParticipation(duty core.Duty, pubkey core.PubKey, allEvents map[core.Duty][]event) error { | ||
| if len(allEvents[duty]) == 0 { |
There was a problem hiding this comment.
not sure this optimisation is worth it, it will never be true in practice
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates parSigEx events in analyseParticipation.
category: feature
ticket: #855