Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: fix builder registration and add teku integration test #957

Merged
merged 11 commits into from
Aug 11, 2022

Conversation

corverroos
Copy link
Contributor

  • Fixes issue with builder registration domain calculation.
  • Also adds teku proposer config endpoint
  • Also fixes registration deadline issue
  • Adds integration test using teku/develop image.

category: feature
ticket: #849

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #957 (495014c) into main (b40678b) will decrease coverage by 0.64%.
The diff coverage is 21.05%.

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   54.58%   53.93%   -0.65%     
==========================================
  Files         116      117       +1     
  Lines       12696    12741      +45     
==========================================
- Hits         6930     6872      -58     
- Misses       4767     4868     +101     
- Partials      999     1001       +2     
Impacted Files Coverage Δ
core/deadline.go 70.90% <0.00%> (ø)
core/validatorapi/teku.go 0.00% <0.00%> (ø)
testutil/beaconmock/options.go 42.67% <0.00%> (-0.14%) ⬇️
testutil/beaconmock/server.go 54.09% <0.00%> (-0.45%) ⬇️
testutil/validatormock/validatormock.go 35.75% <0.00%> (+0.10%) ⬆️
eth2util/signing/signing.go 40.65% <50.00%> (-5.61%) ⬇️
core/validatorapi/validatorapi.go 53.76% <57.14%> (+0.05%) ⬆️
core/validatorapi/router.go 64.72% <66.66%> (-0.04%) ⬇️
core/qbft/qbft.go 71.67% <0.00%> (-10.31%) ⬇️
cmd/bootnode.go 34.30% <0.00%> (-2.71%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 11, 2022
@obol-bulldozer obol-bulldozer bot merged commit 62495dd into main Aug 11, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/registertest branch August 11, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants