Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: missing functions signeddata builder registration #869

Conversation

ciaranmcveigh5
Copy link
Contributor

  • Add missing functions required for vapi implementation

category: feature
ticket: #849

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #869 (498fd1d) into main (827d675) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   54.39%   54.40%           
=======================================
  Files         114      114           
  Lines       12211    12229   +18     
=======================================
+ Hits         6642     6653   +11     
- Misses       4603     4613   +10     
+ Partials      966      963    -3     
Impacted Files Coverage Δ
core/signeddata.go 41.66% <0.00%> (-2.05%) ⬇️
core/qbft/qbft.go 81.97% <0.00%> (+0.85%) ⬆️
dkg/transport.go 66.66% <0.00%> (+12.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827d675...498fd1d. Read the comment docs.

@ciaranmcveigh5 ciaranmcveigh5 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 28, 2022
@obol-bulldozer obol-bulldozer bot merged commit 3fb70be into ObolNetwork:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants