cmd/createcluster: add --num-validators flag
#863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #863 +/- ##
==========================================
- Coverage 54.90% 54.65% -0.26%
==========================================
Files 113 113
Lines 12082 12076 -6
==========================================
- Hits 6634 6600 -34
- Misses 4489 4511 +22
- Partials 959 965 +6
Continue to review full report at Codecov.
|
xenowits
approved these changes
Jul 27, 2022
corverroos
reviewed
Jul 27, 2022
cmd/createcluster.go
Outdated
| @@ -86,7 +87,7 @@ func bindClusterFlags(flags *pflag.FlagSet, config *clusterConfig) { | |||
| flags.StringVar(&config.WithdrawalAddr, "withdrawal-address", defaultWithdrawalAddr, "Ethereum address to receive the returned stake and accrued rewards.") | |||
| flags.StringVar(&config.Network, "network", defaultNetwork, "Ethereum network to create validators for. Options: mainnet, prater, kintsugi, kiln, gnosis.") | |||
| flags.BoolVar(&config.Clean, "clean", false, "Delete the cluster directory before generating it.") | |||
|
|
|||
| flags.IntVar(&config.NumDVs, "validators", 1, "The number of distributed validators needed in the cluster.") | |||
There was a problem hiding this comment.
Please align with create dkg which calls this --num-validators
corverroos
approved these changes
Jul 27, 2022
dB2510
changed the title
--num-validators flag
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
--num-validatorsflag to create cluster command which would facilitate in creation of clusters with multiple DVs.category: feature
ticket: #879