testutil/compose: add definition version matrix test #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 54.78% 55.31% +0.53%
==========================================
Files 111 111
Lines 11425 11534 +109
==========================================
+ Hits 6259 6380 +121
+ Misses 4259 4233 -26
- Partials 907 921 +14
Continue to review full report at Codecov.
|
corverroos
commented
Jul 21, 2022
Comment on lines
92
to
96
| RunTmplFunc: func(data *compose.TmplData) { | ||
| // Node 0 is latest | ||
| pegImageTag(data.Nodes, 1, "v8.0.0") | ||
| pegImageTag(data.Nodes, 2, "v7.0.0") | ||
| pegImageTag(data.Nodes, 3, "v6.0.0") |
There was a problem hiding this comment.
re-enabled this test
corverroos
commented
Jul 21, 2022
Comment on lines
100
to
106
| Name: "definition version matrix with dkg - v1.0.0", | ||
| ConfigFunc: func(conf *compose.Config) { | ||
| conf.KeyGen = compose.KeyGenDKG | ||
| }, | ||
| DefineTmplFunc: func(data *compose.TmplData) { | ||
| // v8.0.0 of charon generates v1.0.0 defnition files. | ||
| pegImageTag(data.Nodes, 0, "v8.0.0") |
corverroos
commented
Jul 21, 2022
| @@ -147,11 +149,9 @@ func TestSmoke(t *testing.T) { | |||
| } | |||
| require.NoError(t, compose.WriteConfig(dir, conf)) | |||
|
|
|||
| cmd := newAutoCmd(func(data *compose.TmplData) { | |||
| data.MonitoringPorts = false | |||
There was a problem hiding this comment.
pull this config up to compose API, see disable-monitoring field.
corverroos
commented
Jul 21, 2022
| @@ -68,19 +68,17 @@ services: | |||
|
|
|||
| prometheus: | |||
| image: prom/prometheus:latest | |||
| {{if .MonitoringPorts}}ports: | |||
There was a problem hiding this comment.
Instead of not binding ports, rather just don't run monitoring at all (since not used if bound). Also saves some resources since less containers.
There was a problem hiding this comment.
actually, we do not monitoring since we rely on alerts for health checks
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compose smoke test for backwards compatibility with v1.0.0 definition version.
Also enable run version matrix test again.
category: test
ticket: #710