Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: support multiple beacon nodes #830

Merged
merged 3 commits into from
Jul 21, 2022
Merged

cmd: support multiple beacon nodes #830

merged 3 commits into from
Jul 21, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jul 21, 2022

Adds support for multiple beacon nodes via eth2 multi client. Adds the --beacon-node-endpoints flags and deprecates --beacon-node-endpoint flag. Updates validatorapi proxy to use active eth2client address.

category: feature
ticket: #552

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #830 (f0a9b6a) into main (abea4c0) will increase coverage by 0.73%.
The diff coverage is 52.50%.

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   54.10%   54.84%   +0.73%     
==========================================
  Files         109      111       +2     
  Lines       10925    11425     +500     
==========================================
+ Hits         5911     6266     +355     
- Misses       4147     4256     +109     
- Partials      867      903      +36     
Impacted Files Coverage Δ
testutil/beaconmock/beaconmock.go 64.19% <ø> (-1.63%) ⬇️
app/app.go 55.25% <31.25%> (+0.19%) ⬆️
core/validatorapi/router.go 65.68% <50.00%> (-1.19%) ⬇️
cmd/run.go 85.29% <66.66%> (-14.71%) ⬇️
testutil/beaconmock/options.go 43.91% <0.00%> (-4.68%) ⬇️
core/deadline.go 64.86% <0.00%> (-3.14%) ⬇️
core/fetcher/fetcher.go 65.07% <0.00%> (-0.52%) ⬇️
cluster/confighash.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abea4c0...f0a9b6a. Read the comment docs.

@corverroos corverroos changed the title p2p: support multiple beacon nodes app: support multiple beacon nodes Jul 21, 2022
@corverroos corverroos changed the title app: support multiple beacon nodes cmd: support multiple beacon nodes Jul 21, 2022
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 21, 2022
@obol-bulldozer obol-bulldozer bot merged commit 6e82ea9 into main Jul 21, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/multibeacon branch July 21, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants