core: fetcher implementation for builder api #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranmcveigh5
commented
Jul 20, 2022
| @@ -6,7 +6,7 @@ linters-settings: | |||
| skip-tests: true | |||
| dupl: | |||
| # tokens count to trigger issue, 150 by default | |||
| threshold: 350 | |||
| threshold: 400 | |||
There was a problem hiding this comment.
another dupl
core/fetcher/fetcher_test.go:163: 163-228 lines are duplicate of core/fetcher/fetcher_test.go:96-161
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
==========================================
- Coverage 54.47% 54.39% -0.08%
==========================================
Files 109 109
Lines 11121 11183 +62
==========================================
+ Hits 6058 6083 +25
- Misses 4168 4203 +35
- Partials 895 897 +2
Continue to review full report at Codecov.
|
corverroos
approved these changes
Jul 20, 2022
| @@ -6,7 +6,7 @@ linters-settings: | |||
| skip-tests: true | |||
| dupl: | |||
| # tokens count to trigger issue, 150 by default | |||
| threshold: 350 | |||
| threshold: 400 | |||
ciaranmcveigh5
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
category: feature
ticket: #809