core/bcast: make lighthouse submit attestations idempotent #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 54.87% 54.57% -0.30%
==========================================
Files 109 109
Lines 10772 10785 +13
==========================================
- Hits 5911 5886 -25
- Misses 3997 4037 +40
+ Partials 864 862 -2
Continue to review full report at Codecov.
|
dB2510
approved these changes
Jul 19, 2022
corverroos
commented
Jul 19, 2022
core/bcast/bcast.go
Outdated
| @@ -81,6 +82,12 @@ func (b Broadcaster) Broadcast(ctx context.Context, duty core.Duty, | |||
| } | |||
|
|
|||
| err = b.eth2Cl.SubmitAttestations(ctx, []*eth2p0.Attestation{&att.Attestation}) | |||
| if err != nil && (strings.Contains(err.Error(), "PriorAttestationKnown") || | |||
| strings.Contains(err.Error(), "No peers on libp2p topic")) { | |||
There was a problem hiding this comment.
don't think nimbus "No peers on libp2p topic " is the same issue, rather remove please: See https://github.com/status-im/nimbus-eth2/blob/88532c61772ed8c065fe7ab2e9204a8c40de4656/docs/the_nimbus_book/src/troubleshooting.md#no-peers-for-topic
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch and ignore lighthouse non-idempotent error. This follows the example set inside goeth2client (but only used for failover in multi-client setup).
category: bug
ticket: #777