Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add non-ghcr tags for dockerhub #812

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Fixes issue that dockerhub images are not pushed. Adds non-ghcr image prefix so dockerhub compatible tags are also produced. See https://github.com/docker/metadata-action#images-input for example.

category: misc
ticket: #781

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #812 (fbc1c47) into main (588181d) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   54.87%   54.42%   -0.45%     
==========================================
  Files         109      109              
  Lines       10772    10772              
==========================================
- Hits         5911     5863      -48     
- Misses       3997     4044      +47     
- Partials      864      865       +1     
Impacted Files Coverage Δ
core/qbft/qbft.go 71.67% <0.00%> (-10.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588181d...fbc1c47. Read the comment docs.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 19, 2022
@obol-bulldozer obol-bulldozer bot merged commit 43de2d8 into main Jul 19, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/fixdockerhub branch July 19, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants