Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg/sync: support relay reconnect #763

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jul 4, 2022

Adds support to DKG sync protocol to seamlessly reconnect on relay circuit.

Also adds support for external bootnode to compose. This was used to test the implementation.

category: feature
ticket: #684

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #763 (b00cb16) into main (616f4da) will increase coverage by 0.43%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   54.35%   54.79%   +0.43%     
==========================================
  Files         107      107              
  Lines       10485    10496      +11     
==========================================
+ Hits         5699     5751      +52     
+ Misses       3937     3896      -41     
  Partials      849      849              
Impacted Files Coverage Δ
dkg/sync/server.go 68.91% <0.00%> (-0.95%) ⬇️
testutil/compose/compose/main.go 0.00% <0.00%> (ø)
testutil/compose/config.go 83.33% <ø> (ø)
testutil/compose/lock.go 70.87% <50.00%> (-2.05%) ⬇️
dkg/sync/client.go 72.00% <75.00%> (ø)
p2p/p2p.go 24.27% <0.00%> (+0.97%) ⬆️
core/qbft/qbft.go 81.97% <0.00%> (+10.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 616f4da...b00cb16. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 5, 2022
@obol-bulldozer obol-bulldozer bot merged commit 59fe53a into main Jul 5, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/reconnectrelay branch July 5, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants