Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: replace hex with base64 for definition_hash #756

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jun 30, 2022

Replace hex string to base64 string for definition_hash in dkg logs.

category: refactor
ticket: #753

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #756 (975dd2b) into main (3836392) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   54.20%   54.17%   -0.03%     
==========================================
  Files         107      107              
  Lines       10476    10476              
==========================================
- Hits         5678     5675       -3     
- Misses       3971     3972       +1     
- Partials      827      829       +2     
Impacted Files Coverage Δ
dkg/dkg.go 52.90% <100.00%> (ø)
app/app.go 57.75% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3836392...975dd2b. Read the comment docs.

@dB2510 dB2510 linked an issue Jun 30, 2022 that may be closed by this pull request
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jul 1, 2022
@obol-bulldozer obol-bulldozer bot merged commit f6b5361 into main Jul 1, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/defhash branch July 1, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition hash log is in hex but in the file it is in b64
2 participants