docs: replace manifest with cluster definition/lock #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
=======================================
Coverage 54.41% 54.41%
=======================================
Files 107 107
Lines 10408 10408
=======================================
+ Hits 5663 5664 +1
Misses 3921 3921
+ Partials 824 823 -1
Continue to review full report at Codecov.
|
xenowits
approved these changes
Jun 23, 2022
| @@ -104,12 +103,12 @@ There are a number of aspects to this trust surface that can be mitigated with a | |||
|
|
|||
| ### Using DKG without the launchpad | |||
|
|
|||
| Charon clients can do a DKG with a manifest file that does not contain operator signatures if you pass a `--no-verify` flag to `charon dkg`. This can be used for testing purposes when strict signature verification is not of the utmost importance. | |||
| Charon clients can do a DKG with a cluster-definition file that does not contain operator signatures if you pass a `--no-verify` flag to `charon dkg`. This can be used for testing purposes when strict signature verification is not of the utmost importance. | |||
There was a problem hiding this comment.
--no-verify flag doesn't exist now, though an issue is open. i suggest we can keep it
Co-authored-by: Abhishek Kumar <[email protected]>
Co-authored-by: Abhishek Kumar <[email protected]>
dB2510
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manifest with cluster definition/lock everywhere in the codebase.
category: docs
ticket: none