app/retry: refactor to not timeout exit duty #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
changed the title
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 55.11% 55.01% -0.10%
==========================================
Files 98 99 +1
Lines 9652 9664 +12
==========================================
- Hits 5320 5317 -3
- Misses 3561 3579 +18
+ Partials 771 768 -3
Continue to review full report at Codecov.
|
xenowits
approved these changes
Jun 5, 2022
| "github.com/obolnetwork/charon/app/errors" | ||
| ) | ||
|
|
||
| // lateFactor defines the number of slots duties may be late. |
There was a problem hiding this comment.
nit
Suggested change
| // lateFactor defines the number of slots duties may be late. | |
| // lateFactor defines the number of slots that the duties may be late. |
| return nil, err | ||
| } | ||
|
|
||
| duration, err := eth2Cl.SlotDuration(ctx) |
There was a problem hiding this comment.
nit: can rename duration to durationPerSlot
| backoffProvider func() func() <-chan time.Time | ||
|
|
||
| wg sync.WaitGroup | ||
| } | ||
|
|
||
| // DoAsync will execute the function including retries on network or context errors. | ||
| // It is intended to be used asynchronously: | ||
| // go retryer.DoAsync(ctx, duty.Slot, "foo", fn) | ||
| func (r *Retryer) DoAsync(parent context.Context, slot int64, name string, fn func(context.Context) error) { | ||
| // go retryer.DoAsync(ctx, duty, "foo", fn) |
There was a problem hiding this comment.
nit
Suggested change
| // go retryer.DoAsync(ctx, duty, "foo", fn) | |
| // USAGE: go retryer.DoAsync(ctx, duty, "foo", fn) |
corverroos
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
retryerto support different timeouts for different duty types. Specificlally,DutyExitshould not timeout since it can be linked to any past or future slot.I had to make it generic, since
retryercannot importcorewhich results in a import cycle. DefiningDeadlineFuncin core also a makes a bit more sense, since thecorepackage owns duties.category: refactor
ticket: #553