Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags: remove peerdb flag #657

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

xenowits
Copy link
Contributor

@xenowits xenowits commented Jun 2, 2022

Remove --p2p-peerdb flag, so peerDB now defaults to a new in-memory database.

category: refactor
ticket: #644

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #657 (5b1ee59) into main (40209f9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #657      +/-   ##
==========================================
+ Coverage   55.00%   55.02%   +0.02%     
==========================================
  Files          98       98              
  Lines        9510     9510              
==========================================
+ Hits         5231     5233       +2     
+ Misses       3528     3527       -1     
+ Partials      751      750       -1     
Impacted Files Coverage Δ
cmd/run.go 100.00% <ø> (ø)
p2p/config.go 62.50% <ø> (ø)
p2p/discovery.go 50.00% <100.00%> (+0.74%) ⬆️
core/qbft/qbft.go 81.89% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40209f9...5b1ee59. Read the comment docs.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 2, 2022
@obol-bulldozer obol-bulldozer bot merged commit 7dc7a73 into main Jun 2, 2022
@obol-bulldozer obol-bulldozer bot deleted the xenowits/delete-peerdb-flag branch June 2, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants