Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/compose: add feature set flags #607

Merged
merged 5 commits into from
May 25, 2022
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented May 24, 2022

Adds the ability to enable different feature sets to compose.

Also fix issue with teku vc config.

category: feature
ticket: #568

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #607 (62f5e45) into main (858032a) will decrease coverage by 0.02%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   56.35%   56.33%   -0.03%     
==========================================
  Files          96       96              
  Lines        9083     9106      +23     
==========================================
+ Hits         5119     5130      +11     
- Misses       3230     3236       +6     
- Partials      734      740       +6     
Impacted Files Coverage Δ
testutil/compose/define.go 40.32% <0.00%> (ø)
testutil/compose/lock.go 59.57% <66.66%> (+0.43%) ⬆️
testutil/compose/config.go 83.33% <100.00%> (ø)
testutil/compose/run.go 88.13% <100.00%> (+7.05%) ⬆️
app/app.go 58.20% <0.00%> (-2.57%) ⬇️
core/qbft/qbft.go 82.13% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858032a...62f5e45. Read the comment docs.

Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 25, 2022
@obol-bulldozer obol-bulldozer bot merged commit 27414e7 into main May 25, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/featureset branch May 25, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants