Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/compose: introduce new and auto commands #600

Merged
merged 2 commits into from
May 24, 2022

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented May 24, 2022

Refactors compose:

  • Decouple new from define: new only creates config.json file, define is now identical to lock and run; it only creates docker-compose files.
  • This adds support for using existing config files, and generating clusters from them
  • Add convenience function compose auto that runs compose define && compose lock && compose run, since this will be the most common use-case.

Result:

compose new --keygen==dkg && compose auto

category: refactor
ticket: #568

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #600 (0a7ae5d) into main (f56ceb3) will decrease coverage by 0.00%.
The diff coverage is 56.00%.

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   54.68%   54.68%   -0.01%     
==========================================
  Files          95       96       +1     
  Lines        8951     8975      +24     
==========================================
+ Hits         4895     4908      +13     
- Misses       3357     3368      +11     
  Partials      699      699              
Impacted Files Coverage Δ
testutil/compose/config.go 82.35% <ø> (ø)
testutil/compose/lock.go 58.75% <0.00%> (-3.75%) ⬇️
testutil/compose/run.go 81.08% <0.00%> (ø)
testutil/compose/define.go 46.06% <45.45%> (-1.37%) ⬇️
testutil/compose/new.go 100.00% <100.00%> (ø)
cmd/createdkg.go 0.00% <0.00%> (ø)
core/qbft/qbft.go 82.13% <0.00%> (+0.43%) ⬆️
app/app.go 63.14% <0.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56ceb3...0a7ae5d. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 24, 2022
@obol-bulldozer obol-bulldozer bot merged commit 6e537c4 into main May 24, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/composenew branch May 24, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants