Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/compose: rename compose config #590

Merged
merged 3 commits into from
May 23, 2022
Merged

Conversation

corverroos
Copy link
Contributor

Renames charon-compose.yml to config.json in order to differentiate and distinguish it from docker-compose.yml.

category: refactor
ticket: #568

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #590 (7079943) into main (969dc9a) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   54.81%   54.88%   +0.07%     
==========================================
  Files          95       95              
  Lines        8898     8890       -8     
==========================================
+ Hits         4877     4879       +2     
+ Misses       3320     3314       -6     
+ Partials      701      697       -4     
Impacted Files Coverage Δ
testutil/compose/config.go 100.00% <ø> (ø)
testutil/compose/run.go 76.66% <ø> (ø)
testutil/compose/define.go 54.05% <100.00%> (+0.76%) ⬆️
testutil/compose/lock.go 62.50% <100.00%> (+1.78%) ⬆️
app/app.go 60.70% <0.00%> (ø)
core/qbft/qbft.go 82.57% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 969dc9a...7079943. Read the comment docs.

Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 23, 2022
@obol-bulldozer obol-bulldozer bot merged commit 16b2c35 into main May 23, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/composerename branch May 23, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants