Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: implement signing todos #519

Merged
merged 1 commit into from
May 13, 2022
Merged

dkg: implement signing todos #519

merged 1 commit into from
May 13, 2022

Conversation

corverroos
Copy link
Contributor

Implement signing and aggregation functions.

category: feature
ticket: #478

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #519 (979b0a5) into main (8236459) will decrease coverage by 0.72%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   55.06%   54.34%   -0.73%     
==========================================
  Files          91       91              
  Lines        8425     8465      +40     
==========================================
- Hits         4639     4600      -39     
- Misses       3176     3253      +77     
- Partials      610      612       +2     
Impacted Files Coverage Δ
dkg/dkg.go 41.37% <0.00%> (-7.49%) ⬇️
core/qbft/qbft.go 77.32% <0.00%> (-8.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8236459...979b0a5. Read the comment docs.

Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from corver/dkgsign to main May 13, 2022 07:30
@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 13, 2022
@obol-bulldozer obol-bulldozer bot merged commit 66349dc into main May 13, 2022
@obol-bulldozer obol-bulldozer bot deleted the corver/dkgsign2 branch May 13, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants