app: log git commit hash #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example |
corverroos
added
the
merge when ready
dB2510
reviewed
Apr 6, 2022
|
|
||
| info, ok := debug.ReadBuildInfo() | ||
| if !ok { | ||
| return hash, timestamp |
There was a problem hiding this comment.
why are we returning unknown strings if it is unable to read build info?
Why not return an error?
There was a problem hiding this comment.
it isn't mission critical, it is just "extra information". And it depends on how the binary was built, there is no guarantee that the data is available. For example go run charon/main.go doesn't include this. Neither does go test. So if we return an error, we cannot go run or go test this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs git commit hash and time on startup. Also set commit hash metric and add to version command.
category: feature
ticket: #367