Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add auto-p2pkey to bootnode command #350

Merged
merged 3 commits into from
Apr 4, 2022
Merged

cmd: add auto-p2pkey to bootnode command #350

merged 3 commits into from
Apr 4, 2022

Conversation

corverroos
Copy link
Contributor

As requested in #317, add support for automatically generating a p2pkey if not found. I decided to enable this default since bootnode.

category: bug
ticket: #317

@corverroos corverroos changed the title cmd: Add auto-p2pkey to bootnode command cmd: add auto-p2pkey to bootnode command Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #350 (ef69b81) into main (90abf45) will increase coverage by 0.07%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   55.36%   55.43%   +0.07%     
==========================================
  Files          60       60              
  Lines        5175     5186      +11     
==========================================
+ Hits         2865     2875      +10     
- Misses       1917     1919       +2     
+ Partials      393      392       -1     
Impacted Files Coverage Δ
cmd/run.go 100.00% <ø> (+4.44%) ⬆️
p2p/k1.go 0.00% <0.00%> (ø)
cmd/bootnode.go 46.83% <46.66%> (+1.38%) ⬆️
app/app.go 64.21% <0.00%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90abf45...ef69b81. Read the comment docs.

@corverroos corverroos merged commit a2d294d into main Apr 4, 2022
@corverroos corverroos deleted the corver/autop2p branch April 4, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants