Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github/workflows: add multi platform docker image #348

Merged
merged 7 commits into from
Apr 6, 2022
Merged

github/workflows: add multi platform docker image #348

merged 7 commits into from
Apr 6, 2022

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Apr 4, 2022 •
edited by corverroos
Loading

Adds multi-platform support for docker image using https://github.com/docker/build-push-action.

category: bug
ticket: #339

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@113aba2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 52ddd0c differs from pull request most recent head 25c2ac6. Consider uploading reports for the commit 25c2ac6 to get more accurate results

@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage        ?   55.82%           
=======================================
  Files           ?       60           
  Lines           ?     5096           
  Branches        ?        0           
=======================================
  Hits            ?     2845           
  Misses          ?     1857           
  Partials        ?      394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113aba2...25c2ac6. Read the comment docs.

@leolara
Copy link
Contributor

leolara commented Apr 4, 2022

I will not review this as I do not know about .github/workflows format

@dB2510 dB2510 added merge when ready Indicates bulldozer bot may merge when all checks pass and removed merge when ready Indicates bulldozer bot may merge when all checks pass labels Apr 5, 2022
corverroos
corverroos approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@corverroos corverroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to update release.yml as well

.github/workflows/build.yml Outdated
@@ -1,4 +1,5 @@
on:
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

.github/workflows/build.yml Outdated
@@ -10,25 +11,40 @@ jobs:
name: Build Docker Image
steps:

- uses: actions/checkout@v2
- name: Checkout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the name, it doesn't really add value. It defaults to actions/checkout@v2 which is clear what it is doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@dB2510 dB2510 changed the title .github/workflows: add multi platform support for docker image .github/workflows: add multi platform docker image Apr 6, 2022
@dB2510 dB2510 changed the title .github/workflows: add multi platform docker image github/workflows: add multi platform docker image Apr 6, 2022
corverroos
corverroos reviewed Apr 6, 2022
View reviewed changes
.github/workflows/release.yml Outdated
- id: get-version
run: |
version=$(echo "${{ github.ref }}" | cut -d / -f 3)
version=$(echo "${{ github.sha }}" | cut -c1-8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this gets a tag, not a sha. So please revert and rename to get-tag

corverroos
corverroos reviewed Apr 6, 2022
View reviewed changes
.github/workflows/release.yml Outdated
name: ${{ github.repository }}/charon
images: |
ghcr.io/obolnetwork/charon/charon
tags: "latest,${{steps.get-version.outputs.version}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only push the tag, build already pushed latest

@dB2510 dB2510 linked an issue Apr 6, 2022 that may be closed by this pull request
Docker image not supporting multiple platforms #339
Closed
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 6, 2022
@obol-bulldozer obol-bulldozer bot merged commit aa154e1 into main Apr 6, 2022
@obol-bulldozer obol-bulldozer bot deleted the dhruv/docker_multi branch April 6, 2022 10:33
@dB2510 dB2510 mentioned this pull request Apr 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corverroos corverroos corverroos approved these changes

Assignees
No one assigned
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image not supporting multiple platforms
3 participants
@dB2510 @leolara @corverroos