cmd: move ctx check before writing to channel #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaloyanTanev
changed the title
pinebit
reviewed
Apr 29, 2024
pinebit
reviewed
Apr 29, 2024
pinebit
approved these changes
Apr 29, 2024
pinebit
reviewed
Apr 29, 2024
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3054 +/- ##
==========================================
- Coverage 54.63% 54.57% -0.06%
==========================================
Files 207 207
Lines 29145 29152 +7
==========================================
- Hits 15922 15911 -11
- Misses 11383 11400 +17
- Partials 1840 1841 +1 ☔ View full report in Codecov by Sentry. |
gsora
approved these changes
Apr 30, 2024
KaloyanTanev
added
the
merge when ready
obol-bulldozer
bot
deleted the
kalo/test-ping-continuously-closed-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix writing to closed channel error.
category: bug
ticket: #3053