Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/validatorapi: fix get validators method #2680

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Nov 7, 2023

Fixes get validators method to convert pubshares to pubkeys.

category: bug
ticket: none

Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1aa0bb4) 53.05% compared to head (a53a49b) 53.03%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
- Coverage   53.05%   53.03%   -0.03%     
==========================================
  Files         202      202              
  Lines       28011    27999      -12     
==========================================
- Hits        14861    14849      -12     
+ Misses      11289    11285       -4     
- Partials     1861     1865       +4     
Files Coverage Δ
core/validatorapi/validatorapi.go 59.59% <0.00%> (+0.88%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 changed the title core/validatorapi: fix get validators method to convert pubshares to pubkeys core/validatorapi: fix get validators method Nov 7, 2023
@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Nov 7, 2023
@obol-bulldozer obol-bulldozer bot merged commit 7172fb6 into main Nov 7, 2023
16 of 17 checks passed
@obol-bulldozer obol-bulldozer bot deleted the dhruv/fixgetvalidators branch November 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants