Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump go version #2648

Merged
merged 5 commits into from
Oct 19, 2023
Merged

*: bump go version #2648

merged 5 commits into from
Oct 19, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Oct 18, 2023

Update Go to 1.21.3 for v0.17 branch release.

category: refactor
ticket: none

gsora and others added 2 commits October 18, 2023 16:09
Bump charon to `go1.21.3`.

This fixes failing govulnchecks https://github.com/ObolNetwork/charon/actions/runs/6504583723.

category: feature
ticket: none
@github-actions github-actions bot added the branch-release PR or Issue linked to a release branch (not main) label Oct 18, 2023
@gsora gsora added the v0.17.1 label Oct 18, 2023
@gsora gsora changed the title *: bump go version (#2638) *: bump go version Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3952eea) 53.77% compared to head (f85193d) 53.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##           main-v0.17    #2648   +/-   ##
===========================================
  Coverage       53.77%   53.77%           
===========================================
  Files             198      198           
  Lines           26946    26946           
===========================================
+ Hits            14490    14491    +1     
+ Misses          10653    10648    -5     
- Partials         1803     1807    +4     
Files Coverage Δ
cluster/definition.go 67.92% <ø> (ø)
cluster/deposit.go 100.00% <ø> (ø)
cluster/distvalidator.go 73.91% <ø> (ø)
cluster/lock.go 56.49% <ø> (ø)
cluster/operator.go 93.61% <ø> (ø)
cluster/registration.go 100.00% <ø> (ø)
eth2util/keystore/keystore.go 66.94% <ø> (ø)
testutil/verifypr/verify.go 63.63% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gsora gsora merged commit 98c5f1c into main-v0.17 Oct 19, 2023
14 checks passed
@gsora gsora deleted the gsora/go_1.21.3 branch October 19, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release PR or Issue linked to a release branch (not main) v0.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants