Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS #2574

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

xenowits
Copy link
Contributor

Add MIN_EPOCHS_FOR_BLOCK_REQUESTS constant to beaconmock.

This should fix failing tests here - https://github.com/ObolNetwork/charon/actions/runs/6002406193/job/16278692464?pr=2564.

category: feature
ticket: none

@xenowits xenowits self-assigned this Sep 11, 2023
@xenowits xenowits changed the title add MIN_EPOCHS_FOR_BLOCK_REQUESTS to bmock testutil/beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2f2d93) 53.75% compared to head (da0a428) 53.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2574   +/-   ##
=======================================
  Coverage   53.75%   53.75%           
=======================================
  Files         200      200           
  Lines       27128    27128           
=======================================
+ Hits        14582    14584    +2     
+ Misses      10724    10722    -2     
  Partials     1822     1822           

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xenowits xenowits changed the title testutil/beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS testutil: add MIN_EPOCHS_FOR_BLOCK_REQUESTS Sep 11, 2023
@xenowits xenowits changed the title testutil: add MIN_EPOCHS_FOR_BLOCK_REQUESTS beaconadd MIN_EPOCHS_FOR_BLOCK_REQUESTS Sep 11, 2023
@xenowits xenowits changed the title beaconadd MIN_EPOCHS_FOR_BLOCK_REQUESTS beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS Sep 11, 2023
@dB2510
Copy link
Contributor

dB2510 commented Sep 11, 2023

@xenowits i think this will also come during testing teku with other beacon nodes. We need to be mindful of testing for this spec constant with other beacon nodes except lighthouse.
cc: @sugh01

@dB2510
Copy link
Contributor

dB2510 commented Sep 11, 2023

For now this will fix the failing integration tests in our CI/CD.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Sep 11, 2023
@obol-bulldozer obol-bulldozer bot merged commit 3abc2e2 into main Sep 11, 2023
19 of 21 checks passed
@obol-bulldozer obol-bulldozer bot deleted the xenowits/static-json branch September 11, 2023 11:20
dB2510 pushed a commit that referenced this pull request Oct 9, 2023
Add `MIN_EPOCHS_FOR_BLOCK_REQUESTS` constant to beaconmock.

This should fix failing tests here - https://github.com/ObolNetwork/charon/actions/runs/6002406193/job/16278692464?pr=2564.

category: feature 
ticket: none
obol-bulldozer bot pushed a commit that referenced this pull request Oct 9, 2023
Add `MIN_EPOCHS_FOR_BLOCK_REQUESTS` constant to beaconmock.

Cherry-pick: #2574 

category: feature 
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants