-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beaconmock: add MIN_EPOCHS_FOR_BLOCK_REQUESTS
#2574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenowits
changed the title
add
testutil/beaconmock: add Sep 11, 2023
MIN_EPOCHS_FOR_BLOCK_REQUESTS
to bmockMIN_EPOCHS_FOR_BLOCK_REQUESTS
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
=======================================
Coverage 53.75% 53.75%
=======================================
Files 200 200
Lines 27128 27128
=======================================
+ Hits 14582 14584 +2
+ Misses 10724 10722 -2
Partials 1822 1822 ☔ View full report in Codecov by Sentry. |
xenowits
changed the title
testutil/beaconmock: add
testutil: add Sep 11, 2023
MIN_EPOCHS_FOR_BLOCK_REQUESTS
MIN_EPOCHS_FOR_BLOCK_REQUESTS
xenowits
changed the title
testutil: add
beaconadd Sep 11, 2023
MIN_EPOCHS_FOR_BLOCK_REQUESTS
MIN_EPOCHS_FOR_BLOCK_REQUESTS
xenowits
changed the title
beaconadd
beaconmock: add Sep 11, 2023
MIN_EPOCHS_FOR_BLOCK_REQUESTS
MIN_EPOCHS_FOR_BLOCK_REQUESTS
dB2510
approved these changes
Sep 11, 2023
For now this will fix the failing integration tests in our CI/CD. |
dB2510
added
the
merge when ready
Indicates bulldozer bot may merge when all checks pass
label
Sep 11, 2023
dB2510
pushed a commit
that referenced
this pull request
Oct 9, 2023
Add `MIN_EPOCHS_FOR_BLOCK_REQUESTS` constant to beaconmock. This should fix failing tests here - https://github.com/ObolNetwork/charon/actions/runs/6002406193/job/16278692464?pr=2564. category: feature ticket: none
obol-bulldozer bot
pushed a commit
that referenced
this pull request
Oct 9, 2023
Add `MIN_EPOCHS_FOR_BLOCK_REQUESTS` constant to beaconmock. Cherry-pick: #2574 category: feature ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MIN_EPOCHS_FOR_BLOCK_REQUESTS
constant to beaconmock.This should fix failing tests here - https://github.com/ObolNetwork/charon/actions/runs/6002406193/job/16278692464?pr=2564.
category: feature
ticket: none