-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil/validatormock: refactor vmock #2545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
==========================================
- Coverage 53.77% 53.49% -0.28%
==========================================
Files 200 202 +2
Lines 27132 27339 +207
==========================================
+ Hits 14589 14624 +35
- Misses 10719 10892 +173
+ Partials 1824 1823 -1
☔ View full report in Codecov by Sentry. |
xenowits
reviewed
Aug 16, 2023
dB2510
force-pushed
the
corver/vmockv2
branch
from
September 25, 2023 05:20
099422f
to
17bce86
Compare
gsora
reviewed
Oct 9, 2023
gsora
approved these changes
Oct 10, 2023
xenowits
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dB2510
added
the
merge when ready
Indicates bulldozer bot may merge when all checks pass
label
Oct 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor validatormock to support lookahead for relevant duties like
DutyPrepareAggregator
andDutySyncContribution
.category: refactor
ticket: #2400