Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil/validatormock: refactor vmock #2545

Merged
merged 15 commits into from
Oct 10, 2023
Merged

testutil/validatormock: refactor vmock #2545

merged 15 commits into from
Oct 10, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Aug 14, 2023

Refactor validatormock to support lookahead for relevant duties like DutyPrepareAggregator and DutySyncContribution.

category: refactor
ticket: #2400

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Attention: 407 lines in your changes are missing coverage. Please review.

Comparison is base (1ca2b47) 53.77% compared to head (5f7139a) 53.49%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
- Coverage   53.77%   53.49%   -0.28%     
==========================================
  Files         200      202       +2     
  Lines       27132    27339     +207     
==========================================
+ Hits        14589    14624      +35     
- Misses      10719    10892     +173     
+ Partials     1824     1823       -1     
Files Coverage Δ
cmd/createdkg.go 72.58% <100.00%> (ø)
core/scheduler/scheduler.go 74.89% <100.00%> (+0.10%) ⬆️
eth2util/network.go 67.39% <ø> (ø)
testutil/compose/run.go 81.00% <100.00%> (ø)
app/app.go 6.72% <0.00%> (ø)
cmd/createcluster.go 59.82% <0.00%> (ø)
testutil/compose/auto.go 0.00% <0.00%> (ø)
app/vmock.go 0.00% <0.00%> (ø)
testutil/validatormock/propose.go 29.57% <54.83%> (ø)
testutil/validatormock/meta.go 0.00% <0.00%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dB2510 dB2510 changed the title wip vmock v2 testutil/validatormock: refactor vmock Sep 28, 2023
@gsora gsora requested a review from xenowits October 9, 2023 08:41
testutil/validatormock/component.go Show resolved Hide resolved
testutil/validatormock/meta.go Show resolved Hide resolved
testutil/validatormock/meta.go Show resolved Hide resolved
testutil/validatormock/component.go Outdated Show resolved Hide resolved
testutil/validatormock/propose.go Outdated Show resolved Hide resolved
testutil/validatormock/propose.go Outdated Show resolved Hide resolved
testutil/compose/auto.go Outdated Show resolved Hide resolved
core/scheduler/scheduler.go Show resolved Hide resolved
Copy link
Contributor

@xenowits xenowits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Oct 10, 2023
@obol-bulldozer obol-bulldozer bot merged commit 871bd33 into main Oct 10, 2023
13 checks passed
@obol-bulldozer obol-bulldozer bot deleted the corver/vmockv2 branch October 10, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants