Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/promauto: support partial resets #2487

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Jul 30, 2023

Refactor Reset method of the ResetGauge to accept a slice of label values to match against, adding support for partial reset, not just a full reset..

category: refactor
ticket: none

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 76.47% and project coverage change: +0.02% 🎉

Comparison is base (4f0d8ba) 53.52% compared to head (959ebb6) 53.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
+ Coverage   53.52%   53.55%   +0.02%     
==========================================
  Files         198      198              
  Lines       26757    26732      -25     
==========================================
- Hits        14321    14315       -6     
+ Misses      10648    10633      -15     
+ Partials     1788     1784       -4     
Files Changed Coverage Δ
app/metrics.go 0.00% <ø> (ø)
app/monitoringapi.go 50.57% <0.00%> (+2.22%) ⬆️
app/peerinfo/peerinfo.go 72.22% <0.00%> (+4.44%) ⬆️
p2p/p2p.go 20.52% <0.00%> (ø)
app/promauto/resetgauge.go 93.10% <100.00%> (+1.79%) ⬆️
core/scheduler/metrics.go 100.00% <100.00%> (+17.64%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Aug 1, 2023
@obol-bulldozer obol-bulldozer bot merged commit c70858e into main Aug 1, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/resetmatching branch August 1, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants