Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fix error message #2372

Merged
merged 1 commit into from
Jun 30, 2023
Merged

cmd: fix error message #2372

merged 1 commit into from
Jun 30, 2023

Conversation

xenowits
Copy link
Contributor

Fix non-intuitive error message in create cluster command.

category: refactor
ticket: #2340

@xenowits xenowits self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (3544cff) 53.54% compared to head (e1e89a3) 53.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2372      +/-   ##
==========================================
+ Coverage   53.54%   53.58%   +0.04%     
==========================================
  Files         192      192              
  Lines       25929    25931       +2     
==========================================
+ Hits        13883    13896      +13     
+ Misses      10322    10313       -9     
+ Partials     1724     1722       -2     
Impacted Files Coverage Δ
cmd/createcluster.go 59.07% <100.00%> (+0.57%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 30, 2023
@obol-bulldozer obol-bulldozer bot merged commit 67e0c0d into main Jun 30, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/fix-err-msg branch June 30, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants