Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkg: sync privkeylock before exiting #2257

Merged
merged 9 commits into from
Jun 1, 2023

Commits on May 31, 2023

  1. app/privkeylock: add way of synchronizing callers before privkey lock…

    … deletion
    
    Add `Done()` method that blocks until the `Run()` method finishes its course.
    
    `Run()` is supposed to be executed in a goroutine, and since we can't control the scheduler it might be scheduled *after* the `main` one exits, leading to the `ctx.Done()` code path to never be executed.
    
    Add `Done()`, caller can block on untile `Run()` finishes its execution.
    
    Callers must cancel the `Run()` context, then call `Done()`.
    gsora committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e912abd View commit details
    Browse the repository at this point in the history
  2. dkg: update privkey lock to block until privkey lock file is deleted

    Also modifies the DKG run test to check that all privkey locks are deleted.
    gsora committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f6d7ba5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ce6a8d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d7e45b View commit details
    Browse the repository at this point in the history
  5. Update dkg/dkg.go

    Co-authored-by: Abhishek Kumar <[email protected]>
    gsora and xenowits authored May 31, 2023
    Configuration menu
    Copy the full SHA
    142e641 View commit details
    Browse the repository at this point in the history
  6. Update dkg/dkg.go

    Co-authored-by: Abhishek Kumar <[email protected]>
    gsora and xenowits authored May 31, 2023
    Configuration menu
    Copy the full SHA
    66b24b7 View commit details
    Browse the repository at this point in the history
  7. app/privkeylock: don't contaminate privkeylock with concerns it shoul…

    …dn't have
    
    dkg has the concurrency problem, so make it responsible for the fix as well.
    gsora committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a0dd412 View commit details
    Browse the repository at this point in the history
  8. Update dkg/dkg.go

    Co-authored-by: Abhishek Kumar <[email protected]>
    gsora and xenowits authored May 31, 2023
    Configuration menu
    Copy the full SHA
    9eb9dd6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. cleanup

    corverroos committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    8fb0237 View commit details
    Browse the repository at this point in the history