-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dkg: sync privkeylock before exiting #2257
Merged
Merged
Commits on May 31, 2023
-
app/privkeylock: add way of synchronizing callers before privkey lock…
… deletion Add `Done()` method that blocks until the `Run()` method finishes its course. `Run()` is supposed to be executed in a goroutine, and since we can't control the scheduler it might be scheduled *after* the `main` one exits, leading to the `ctx.Done()` code path to never be executed. Add `Done()`, caller can block on untile `Run()` finishes its execution. Callers must cancel the `Run()` context, then call `Done()`.
Configuration menu - View commit details
-
Copy full SHA for e912abd - Browse repository at this point
Copy the full SHA e912abdView commit details -
dkg: update privkey lock to block until privkey lock file is deleted
Also modifies the DKG run test to check that all privkey locks are deleted.
Configuration menu - View commit details
-
Copy full SHA for f6d7ba5 - Browse repository at this point
Copy the full SHA f6d7ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce6a8d - Browse repository at this point
Copy the full SHA 9ce6a8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d7e45b - Browse repository at this point
Copy the full SHA 7d7e45bView commit details -
Co-authored-by: Abhishek Kumar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 142e641 - Browse repository at this point
Copy the full SHA 142e641View commit details -
Co-authored-by: Abhishek Kumar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66b24b7 - Browse repository at this point
Copy the full SHA 66b24b7View commit details -
app/privkeylock: don't contaminate privkeylock with concerns it shoul…
…dn't have dkg has the concurrency problem, so make it responsible for the fix as well.
Configuration menu - View commit details
-
Copy full SHA for a0dd412 - Browse repository at this point
Copy the full SHA a0dd412View commit details -
Co-authored-by: Abhishek Kumar <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9eb9dd6 - Browse repository at this point
Copy the full SHA 9eb9dd6View commit details
Commits on Jun 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8fb0237 - Browse repository at this point
Copy the full SHA 8fb0237View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.