Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: add pre-generate registrations to lock v1.7 #2205

Merged
merged 3 commits into from
May 18, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented May 18, 2023

Adds pre-generate validator builder registrations to lock file v1.7.0.

category: feature
ticket: #2172

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 72.92% and project coverage change: +0.11 🎉

Comparison is base (dd96155) 53.48% compared to head (15b1f37) 53.60%.

❗ Current head 15b1f37 differs from pull request most recent head 9d727a1. Consider uploading reports for the commit 9d727a1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
+ Coverage   53.48%   53.60%   +0.11%     
==========================================
  Files         185      186       +1     
  Lines       24082    24237     +155     
==========================================
+ Hits        12881    12992     +111     
- Misses       9606     9637      +31     
- Partials     1595     1608      +13     
Impacted Files Coverage Δ
app/featureset/featureset.go 100.00% <ø> (ø)
cluster/version.go 100.00% <ø> (ø)
dkg/dkg.go 57.36% <63.38%> (-0.08%) ⬇️
cluster/lock.go 60.45% <68.88%> (+0.99%) ⬆️
cluster/ssz.go 68.08% <69.81%> (-0.38%) ⬇️
cluster/registration.go 87.50% <87.50%> (ø)
cluster/distvalidator.go 91.50% <91.17%> (-0.39%) ⬇️
cluster/definition.go 66.93% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dB2510
Copy link
Contributor Author

dB2510 commented May 18, 2023

Thanks @gsora for the pair programming session 🚀

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label May 18, 2023
@obol-bulldozer obol-bulldozer bot merged commit 3af7a70 into main May 18, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/lockreg branch May 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants