Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

precommit: lint importing of testutil #2143

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Conversation

corverroos
Copy link
Contributor

Extend the run_regexp.sh linter to check for testutil imports in any non-test package.

category: misc
ticket: #1683

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.16 ⚠️

Comparison is base (19b3263) 53.39% compared to head (ecc1503) 53.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   53.39%   53.24%   -0.16%     
==========================================
  Files         174      174              
  Lines       22845    22849       +4     
==========================================
- Hits        12198    12165      -33     
- Misses       9176     9215      +39     
+ Partials     1471     1469       -2     
Impacted Files Coverage Δ
app/app.go 6.70% <ø> (ø)
app/vmock.go 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 28, 2023
@obol-bulldozer obol-bulldozer bot merged commit 0cb9117 into main Apr 28, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/linttestutil branch April 28, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants