Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/sigagg: verify aggregated signature #2123

Merged
merged 4 commits into from
Apr 26, 2023
Merged

Conversation

xenowits
Copy link
Contributor

Verify reconstructed aggregated signature.

Fixes OBOL-17 of sigp audit.

category: feature
ticket: #2122

@xenowits xenowits self-assigned this Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 37.83% and project coverage change: +0.01 🎉

Comparison is base (b083440) 53.36% compared to head (7c2da16) 53.37%.

❗ Current head 7c2da16 differs from pull request most recent head 1a5e62c. Consider uploading reports for the commit 1a5e62c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   53.36%   53.37%   +0.01%     
==========================================
  Files         174      174              
  Lines       22766    22797      +31     
==========================================
+ Hits        12148    12168      +20     
- Misses       9156     9167      +11     
  Partials     1462     1462              
Impacted Files Coverage Δ
app/app.go 6.67% <0.00%> (-0.03%) ⬇️
core/signeddata.go 43.98% <0.00%> (-0.45%) ⬇️
core/sigagg/sigagg.go 59.09% <53.84%> (+4.54%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

core/sigagg/sigagg.go Outdated Show resolved Hide resolved
core/sigagg/sigagg.go Outdated Show resolved Hide resolved
@xenowits xenowits added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 26, 2023
@obol-bulldozer obol-bulldozer bot merged commit 6cb8645 into main Apr 26, 2023
@obol-bulldozer obol-bulldozer bot deleted the xenowits/obol-17 branch April 26, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants