Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbls: remove legacy Kryptology-based code #2091

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Apr 12, 2023

This PR removes the old tbls package content, and replaces it with tbls/v2 content.

As a consequence, the tbls/v2 package doesn't exist anymore.

All imports have been refactored to accomodate this change.

Kryptology tbls.Implementation will be removed on a follow-up PR.

category: refactor
ticket: #2055

@gsora gsora added the refactor Code refactoring label Apr 12, 2023
@gsora gsora self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 84.31% and project coverage change: +0.04 🎉

Comparison is base (ed5d746) 53.59% compared to head (521c027) 53.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2091      +/-   ##
==========================================
+ Coverage   53.59%   53.64%   +0.04%     
==========================================
  Files         174      172       -2     
  Lines       22697    22411     -286     
==========================================
- Hits        12165    12022     -143     
+ Misses       9015     8911     -104     
+ Partials     1517     1478      -39     
Impacted Files Coverage Δ
app/app.go 7.81% <0.00%> (ø)
cluster/distvalidator.go 91.89% <0.00%> (ø)
tbls/herumi.go 55.20% <ø> (ø)
tbls/kryptology.go 47.70% <ø> (ø)
tbls/tbls.go 100.00% <ø> (ø)
testutil/validatormock/validatormock.go 31.57% <0.00%> (ø)
eth2util/signing/signing.go 36.73% <50.00%> (ø)
eth2util/keystore/keystore.go 52.67% <77.77%> (ø)
core/validatorapi/validatorapi.go 58.29% <83.33%> (ø)
dkg/dkg.go 59.38% <84.00%> (ø)
... and 14 more

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 12, 2023
@obol-bulldozer obol-bulldozer bot merged commit cca6d5e into main Apr 12, 2023
@obol-bulldozer obol-bulldozer bot deleted the gsora/remove_old_tbls branch April 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants