Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracker: ensure success/fail/expected counters #2080

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

corverroos
Copy link
Contributor

@corverroos corverroos commented Apr 11, 2023

Adds success/failure/expected counters for both peer participation and overall duty. This allows improving our dashboard to show duty and participation percentage success/failure with simple queries.

category: misc
ticket: #2034

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 61.53% and project coverage change: +0.17 🎉

Comparison is base (ee11175) 53.33% compared to head (794c752) 53.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
+ Coverage   53.33%   53.51%   +0.17%     
==========================================
  Files         174      174              
  Lines       22609    22625      +16     
==========================================
+ Hits        12059    12108      +49     
+ Misses       9043     9010      -33     
  Partials     1507     1507              
Impacted Files Coverage Δ
core/tracker/tracker.go 75.57% <61.53%> (-1.21%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Apr 11, 2023
@obol-bulldozer obol-bulldozer bot merged commit c968878 into main Apr 11, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/improvemtrics branch April 11, 2023 10:30
LukeHackett12 pushed a commit that referenced this pull request Apr 11, 2023
Adds success/failure/expected counters for both peer participation and overall duty. This allows improving our dashboard to show duty and participation percentage success/failure with simple queries.

category: misc
ticket: #2034
obol-bulldozer bot pushed a commit that referenced this pull request Apr 11, 2023
Adds success/failure/expected counters for both peer participation and overall duty. This allows improving our dashboard to show duty and participation percentage success/failure with simple queries.

category: misc
ticket: #2034
cherry-pick: #2080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants