p2p: support zero length request protos #1957
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
+ Coverage 55.45% 55.82% +0.36%
==========================================
Files 174 174
Lines 22297 22298 +1
==========================================
+ Hits 12365 12447 +82
+ Misses 8361 8272 -89
- Partials 1571 1579 +8
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Mar 28, 2023
| }, | ||
| readersByProtocol: map[protocol.ID]func(s network.Stream) pbio.Reader{ | ||
| pID: func(s network.Stream) pbio.Reader { return legacyReadWriter{s} }, | ||
| // Request readers are allowed to read zero bytes, this is because the legacy protocol |
There was a problem hiding this comment.
Suggested change
| // Request readers are allowed to read zero bytes, this is because the legacy protocol | |
| // Request readers are allowed to read zero bytes, in order to support the legacy protocol |
| reqReadersByProtocol: map[protocol.ID]func(s network.Stream) pbio.Reader{ | ||
| pID: func(s network.Stream) pbio.Reader { return legacyReadWriter{stream: s, allowZeroRead: true} }, | ||
| }, | ||
| // Response readers are not allowed to read zero bytes, this is because the legacy protocol |
There was a problem hiding this comment.
Suggested change
| // Response readers are not allowed to read zero bytes, this is because the legacy protocol | |
| // Response readers are not allowed to read zero bytes, in order to support the legacy protocol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by length-delimited upgrades which assumed that legacy-stream-delimited protocols handled requests and responses the same while it didn't. It allowed zero length requests while it didn't allow zero-length responses. This aligns the new implementation with that.
category: bug
ticket: #1956