dkg: add --publish flag to upload lock file #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 54.69% // Head: 54.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 54.69% 54.67% -0.03%
==========================================
Files 166 167 +1
Lines 21989 22067 +78
==========================================
+ Hits 12027 12065 +38
- Misses 8385 8412 +27
- Partials 1577 1590 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xenowits
reviewed
Feb 9, 2023
xenowits
reviewed
Feb 9, 2023
xenowits
reviewed
Feb 9, 2023
xenowits
reviewed
Feb 9, 2023
xenowits
reviewed
Feb 9, 2023
xenowits
reviewed
Feb 9, 2023
corverroos
reviewed
Feb 9, 2023
corverroos
reviewed
Feb 9, 2023
corverroos
reviewed
Feb 9, 2023
corverroos
approved these changes
Feb 9, 2023
dkg/dkg_test.go
Outdated
| expectedReceives-- | ||
| } | ||
|
|
||
| t.Log("All keystores received 🎉") | ||
| } | ||
|
|
||
| if publish { | ||
| require.Equal(t, <-receivedLockfile, true) |
There was a problem hiding this comment.
I think you expect more than 1 receivedLockfile
LukeHackett12
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds publish flag to dkg and create cluster commands to upload the lock file generated to out api. This introduces the new concept of our launchpad api, so added a configurable address with prod as default.
category: feature
ticket: #1492