Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracker2: add tracker2 package #1666

Merged
merged 3 commits into from
Jan 24, 2023
Merged

core/tracker2: add tracker2 package #1666

merged 3 commits into from
Jan 24, 2023

Conversation

dB2510
Copy link
Contributor

@dB2510 dB2510 commented Jan 19, 2023

Adds refactored tracker logic as tracker2 package in core/tracker package.

category: refactor
ticket: #1478

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 54.51% // Head: 54.53% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (392d330) compared to base (095a998).
Patch coverage: 4.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1666      +/-   ##
==========================================
+ Coverage   54.51%   54.53%   +0.02%     
==========================================
  Files         157      158       +1     
  Lines       20024    20178     +154     
==========================================
+ Hits        10917    11005      +88     
- Misses       7656     7720      +64     
- Partials     1451     1453       +2     
Impacted Files Coverage Δ
core/consensus/component.go 61.51% <0.00%> (-0.40%) ⬇️
core/interfaces.go 0.00% <ø> (ø)
core/tracking.go 0.00% <0.00%> (ø)
core/sigagg/sigagg.go 54.54% <100.00%> (+2.16%) ⬆️
dkg/transport.go 53.70% <0.00%> (-12.97%) ⬇️
app/app.go 64.06% <0.00%> (-1.09%) ⬇️
p2p/bootnode.go 0.00% <0.00%> (ø)
cmd/createcluster.go 53.15% <0.00%> (+<0.01%) ⬆️
core/priority/prioritiser.go 61.69% <0.00%> (+1.20%) ⬆️
app/vmock.go 74.61% <0.00%> (+1.55%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

)

var (
participationGauge = promauto.NewGaugeVec(prometheus.GaugeOpts{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can create duplicate metrics, suggest only moving metrics here once they are "enabled" in v2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tracker2 in metrics naming to avoid duplication, v2 will be behind a featureflag until we are confident. These metrics were needed since I copy pasted most of the code and metrics was also part of it.
Will address this in my next PR to wire and add tests.

@dB2510 dB2510 added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 24, 2023
@obol-bulldozer obol-bulldozer bot merged commit 760bcef into main Jan 24, 2023
@obol-bulldozer obol-bulldozer bot deleted the dhruv/tracker2 branch January 24, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants