-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/tracker2: add tracker2 package #1666
Conversation
14e0062
to
8417bb7
Compare
Codecov ReportBase: 54.51% // Head: 54.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
==========================================
+ Coverage 54.51% 54.53% +0.02%
==========================================
Files 157 158 +1
Lines 20024 20178 +154
==========================================
+ Hits 10917 11005 +88
- Misses 7656 7720 +64
- Partials 1451 1453 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
) | ||
|
||
var ( | ||
participationGauge = promauto.NewGaugeVec(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can create duplicate metrics, suggest only moving metrics here once they are "enabled" in v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added tracker2
in metrics naming to avoid duplication, v2 will be behind a featureflag until we are confident. These metrics were needed since I copy pasted most of the code and metrics was also part of it.
Will address this in my next PR to wire and add tests.
Adds refactored tracker logic as tracker2 package in
core/tracker
package.category: refactor
ticket: #1478